Page 1 of 1

missing flags in INCLUDES

Posted: Fri Mar 04, 2011 1:30 pm
by mverstra
Hello,

following some comments in the previous thread and some emails, I believe something is missing from CFLAGS, but have no idea how to put it back: when specifying

with_math_flavor="gsl"
with_math_incs="-I/gpfs/apps/GSL/1.9/64/include"
with_math_libs="-L/gpfs/apps/GSL/1.9/64/lib/gsl -lgsl"

the configure claims that gsl is unusable because the include header files are missing. In the test compilation line it is _not_ using the given -I option, so I think that the _incs are not added to CFLAGS / FCFLAGS

If I add (thanks jmb):
CFLAGS_EXTRA = -I/gpfs/apps/GSL/1.9/64/include

then it works for the configure but fails to find the includes at 01_gsl compile time...
I think the with_math_incs should be included by default, no?

In config/scripts/make-makefiles-corelibs I find:

# FIXME: hard-coded include list
include_dirs = ["incs"]

which begs for the addition of the other (fft, math etc...) inc variables. This goes into the INCLUDES variable, and compiles correctly. Yann? Some feedback when you get back?

Matthieu

Re: missing flags in INCLUDES

Posted: Sat Mar 05, 2011 3:41 pm
by jbeuken
Matth,

now, I have a bot ( buda_gcc45_gsl ) and I put in the .ac file

with_math_flavor = gsl
with_math_incs = -I/usr/local/gsl/include
with_math_libs = -L/usr/local/gsl/lib -lgsl
CFLAGS_EXTRA = -I/usr/local/gsl/include

and

Code: Select all

 ./configure  && make && make tests

works and the waterfall is green !

see : http://www.abinit.org:8012/builders/bud ... l/builds/0

the installation of GSL is not very "standard" : I use --prefix=/usr/local/gsl instead of --prefix=/usr/local

jmb

Re: missing flags in INCLUDES

Posted: Sat Mar 05, 2011 7:16 pm
by mverstra
Hello Jimmy boy,

no no - /usr/local/gsl _is_ standard. You give the include directory, and the include statements contain gsl/yourfile.h
I still believe that there is a flag insertion missing :)


Matthieu

Re: missing flags in INCLUDES

Posted: Sat Mar 05, 2011 8:58 pm
by jbeuken
Matth,

Sorry, but I don't understand... :oops:

where is your gsl/yourfile.h ?
you also give the include statements :

with_math_incs="-I/gpfs/apps/GSL/1.9/64/include"
FLAGS_EXTRA = -I/gpfs/apps/GSL/1.9/64/include


I don't understand why the compilation doesn't work...

but yes , I agree with you concerning the problem of inclusion of math_incs into INCLUDES variable...

cheers,

jmb

Re: missing flags in INCLUDES

Posted: Mon Mar 07, 2011 2:30 pm
by mverstra
jbeuken wrote:where is your gsl/yourfile.h ?

just an example: gsl header files are referenced explicitly with the subdirectory gsl/ and so your bot _is_ using a default directory for the header files.

you also give the include statements :

with_math_incs="-I/gpfs/apps/GSL/1.9/64/include"
FLAGS_EXTRA = -I/gpfs/apps/GSL/1.9/64/include


I don't understand why the compilation doesn't work...

The configure test is on a C executable, so I had to add
FCFLAGS+=" -I/gpfs/apps/GSL/1.9/64/include "
as well. It works now!

but yes , I agree with you concerning the problem of inclusion of math_incs into INCLUDES variable...

cheers,

jmb

hai! So des. Biru-wo nomimaska?

Matthieu

Re: missing flags in INCLUDES  [SOLVED]

Posted: Wed Mar 16, 2011 1:36 pm
by pouillon
There may be a design flaw in the MATH connector for GSL. I'll check it when I have time.