Dead code in mixing

Documentation, Web site and code modifications

Moderators: baguetl, routerov

Locked
dcaliste
Posts: 44
Joined: Thu Oct 22, 2009 9:15 am
Contact:

Dead code in mixing

Post by dcaliste » Fri Feb 25, 2011 4:46 pm

Hello,

In my current 6.7 branch, I've put all mixing routines in a unique directory 56_mixing. Now, that they have been isolated, I'm looking at simplifying them. I've found several dead parts in these routines:
- in sqnormm_v(), mult is always 1 so the do loop is useless ;
- in dotprodm_v(), mult1 and mult2 are also always 1 ;
- in dotprodm_v(), cpldot is always 1 so the else part of the if is useless.

Is this code relevant for future use or can I remove it to have smaller and easier to read routines ?

Damien.

User avatar
pouillon
Posts: 651
Joined: Wed Aug 19, 2009 10:08 am
Location: Spain
Contact:

Re: Dead code in mixing

Post by pouillon » Wed Mar 16, 2011 1:51 pm

Seeing the absence of answers, it seems that nobody is planning to do anything on that part. I personally always welcome the removal of dead code. Just ask Xavier for confirmation.
Yann Pouillon
Simune Atomistics
Donostia-San Sebastián, Spain

Locked